search

CodeForBc / codeforbc-web

https://codeforbc-web.vercel.app
2 stars 0 forks source link

[Feature] Mission Overview Component #49

Closed Unknown-0perator closed 3 months ago

Unknown-0perator commented 3 months ago

This PR addresses https://github.com/CodeForBc/codeforbc-web/issues/26#issuecomment-2128277735 mission overview

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
codeforbc-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2024 6:32pm
CorreyL commented 3 months ago

@Unknown-0perator What do you think of the commits I pushed?

The rationale here is that I noticed that these two very similar components were being duplicated, so I figured we could have MissionOverview be used on the Join Us page as well, but since the Home Page one has a different set of buttons, we could pass the buttons as children.

CorreyL commented 3 months ago

@CorreyL Thanks, it looks much better now.

One more thing: the heading on the Join Us page should be h1 and on the Home page, it should be h2.

Do you think we should pass a headingType prop, or is it not that important?

Thanks for pointing that out, yeah I think it would make sense to make it an adjustable variable as a prop then, assuming that these choices were intentional design decisions from the design team.

I've implemented that in 6f05398

Unknown-0perator commented 3 months ago

Thanks @CorreyL, looks good to me also @nam-m, @immangat, @bilred, can one of you do a quick review? Thanks.