search

CodeForFoco / codeforfoco.github.io

Code for Foco's website.
http://codeforfoco.org
MIT License
9 stars 24 forks source link

Modified information removed ul's to conform to the site's css #101

Closed deidyomega closed 7 years ago

deidyomega commented 7 years ago

The site's CSS removes UL's. I imagine for nav. I've removed them from my .md as it doesn't look good currently.

abettermap commented 7 years ago

Hmmm <ul> would be nice. I'll take a look this weekend when I'm not on a phone. If it's not an easy fix I'll just merge your PR.

deidyomega commented 7 years ago

If I find and fix it, would you accept my PR?

abettermap commented 7 years ago

Yep. Sorry if slow turnaround for PR's though, 9-to-5 usually means weekends-only for volunteer stuff.

abettermap commented 7 years ago

Plenty of other contributors with same permissions though, so maybe someone will beat me to it. If not... weekend.

abettermap commented 7 years ago

Ok I opened an issue for the list problem: #103

Going to look into it shortly...

abettermap commented 7 years ago

For some reason I can't get your post to show up at all. I've tried changing the content, duplicating the file with a different name, and it still doesn't show up. I was able to edit others' posts and duplicate them as a test with no problem, but yours doesn't show up.

It's not a caching thing as I restarted Jekyll. Also tried checking out the file at a previous commit. Also made it sure the template doesn't have some kind of item limit.

It's working for you I take it (except for #102), so any ideas?

JordanMajd commented 7 years ago

The post is not displaying because the date is in the future. 

date:  2017-07-22 18:30

Should be:

date:  2017-06-22 18:30

EDITED There is a a build command option called future (It can be set in the the site's _config.yml), that when set to true allows posts with a date in the future to be published. It seems like github pages sets it to true, because this post is published on the actual site. More info in the Jekyll docs.

deidyomega commented 7 years ago

Ok! I've fixed the date, and went back to the version prior to the removal of the \<ul>'s

@JordanMajd - Yea, I noticed it was live on the production site, which was confusing to me.

abettermap commented 7 years ago

Good to know about the future thing, that was a bugger to troubleshoot.