search

CodeForFoco / codeforfoco.github.io

Code for Foco's website.
http://codeforfoco.org
MIT License
9 stars 24 forks source link

Investigate build issues. #132

Closed JordanMajd closed 7 years ago

JordanMajd commented 7 years ago

Builds worked fine up until the merge of last week's minutes. We reverted to the last built commit and the repository still won't build.

abettermap commented 7 years ago

The important part of GH's response to David's support request:

Here's the full error we're seeing on our side:

Liquid Exception: no implicit conversion of Integer into String in /_layouts/default.html
            Fatal: TypeError
                   no implicit conversion of Integer into String

It looks like the cause of this is a bug in Jekyll, the fix for which is quite new, and has yet to be incorporated into GitHub Pages:

https://github.com/jekyll/jekyll/pull/6281

While we're working on fixing that, you should be able to resolve this error by changing the value of title: in your 404.html file:

https://github.com/CodeForFoco/codeforfoco.github.io/blob/master/404.html#L3

Can you try updating that to be a string, such as "404" instead of 404?

abettermap commented 7 years ago

I made the change. I'll leave this open for a sec until we know if build worked.

abettermap commented 7 years ago

Happy green checkmark so i'm calling it good:

image

abettermap commented 7 years ago

Ok did some minor triage and pushed things up. I think we have all the commits we need again but i'll hang on to my backup branch for a bit. Build succeeded after push, but holler if any problems.