4 developers have a shared easily deployed docker environment for balancer backend

[dherbst]

The only thing I had to do was run DONT_PASS_SSH_KEYS=1 make build-project to get it to work, but once I did that I was able to run make launch-local-project and it ran the docker container.

LGTM

[jusjayson]

Thanks for finding that! I'll make an update to the makefile before pushing, since (as you mentioned) repos are all public

On Tue, Jun 20, 2023, 6:45 PM Darrel Herbst @.***> wrote:

The only thing I had to do was run DONT_PASS_SSH_KEYS=1 make build-project to get it to work, but once I did that I was able to run make launch-local-project and it ran the docker container.

LGTM

— Reply to this email directly, view it on GitHub https://github.com/CodeForPhilly/balancer-backend/pull/5#issuecomment-1599674811, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADQ7FNYRWUY2KS2OFZ75Z2DXMIRZNANCNFSM6AAAAAAZKSUZ7Q . You are receiving this because you authored the thread.Message ID: @.***>

[joshuagerstein]

When I try to run make in windows, I get the following error:

if ! [ -d Python-Docker ]; then\
        git clone https://github.com/jusjayson/Python-Docker.git;\
fi
[ was unexpected at this time.
make: *** [Makefile:44: pull-python-docker] Error 255

I don't know makefile syntax well enough to propose a way to make it work without bash commands.

[jusjayson]

Possible Darrel's discovery will fix this. Will update and push tomorrow morning

On Wed, Jun 21, 2023, 11:45 PM Joshua Gerstein @.***> wrote:

When I try to run make in windows, I get the following error:

if ! [ -d Python-Docker ]; then\ git clone https://github.com/jusjayson/Python-Docker.git;\ fi [ was unexpected at this time. make: *** [Makefile:44: pull-python-docker] Error 255

I don't know makefile syntax well enough to propose a way to make it work without bash commands.

— Reply to this email directly, view it on GitHub https://github.com/CodeForPhilly/balancer-backend/pull/5#issuecomment-1601971479, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADQ7FN5NDUG4GGLK7GCOC7TXMO5ULANCNFSM6AAAAAAZKSUZ7Q . You are receiving this because you authored the thread.Message ID: @.***>

[jusjayson]

Can you also open an issue about checking windows compatibility? I need to look into how windows handles make commands

On Wed, Jun 21, 2023, 11:46 PM Jayson Dorsett @.***> wrote:

Possible Darrel's discovery will fix this. Will update and push tomorrow morning

On Wed, Jun 21, 2023, 11:45 PM Joshua Gerstein @.***> wrote:

When I try to run make in windows, I get the following error:

if ! [ -d Python-Docker ]; then\ git clone https://github.com/jusjayson/Python-Docker.git;\ fi [ was unexpected at this time. make: *** [Makefile:44: pull-python-docker] Error 255

I don't know makefile syntax well enough to propose a way to make it work without bash commands.

— Reply to this email directly, view it on GitHub https://github.com/CodeForPhilly/balancer-backend/pull/5#issuecomment-1601971479, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADQ7FN5NDUG4GGLK7GCOC7TXMO5ULANCNFSM6AAAAAAZKSUZ7Q . You are receiving this because you authored the thread.Message ID: @.***>

[dherbst]

LGTM, merging.