search

CodeForPhilly / chime

COVID-19 Hospital Impact Model for Epidemics
https://codeforphilly.github.io/chime/
MIT License
205 stars 151 forks source link

Create generic PR template #515

Closed BrianThomasRoss closed 4 years ago

BrianThomasRoss commented 4 years ago

:tada:

ckoerber commented 4 years ago

Regarding:

  • [ ] Runs without error or warning

I also check a lot that the web interface was tested. Not sure how to word this.

BrianThomasRoss commented 4 years ago

Regarding:

  • [ ] Runs without error or warning

I also check a lot that the web interface was tested. Not sure how to word this.

Could add:

If that sounds right?

BrianThomasRoss commented 4 years ago

Hi @BrianThomasRoss , Sorry I'm not entirely sure I'm understanding how this is intended to work. Is the intent to have the creator of every PR check each of these 6 boxes before initiating a PR? If so, that might add a lot of friction. Would it make sense to also offer a 'check all' option so they can do this with 1 click? Let me know if I'm misinterpreting this one.

This was more intended as a tool for the reviewer