CodeForPhilly / chime

COVID-19 Hospital Impact Model for Epidemics
https://codeforphilly.github.io/chime/
MIT License
205 stars 151 forks source link

Refactor module #545

Closed jlubken closed 4 years ago

jlubken commented 4 years ago

Changelog entry

Closes #546 Closes #186 Closes #351 PARAMETERS was previously implemented. Closes #245

jlubken commented 4 years ago

@BrianThomasRoss @dsgit1 @ckoerber @ecsmyth Let's figure out the python packaging for the dash app.

Maybe move the dash app code and app into src/penn_chime/view so it is installed with the penn_chime module. Maybe add the dash app code as part of the penn_chime module and call it from a small script like st_app.py is doing here. Ensure that the templates for i18n are included in the module.

Right now setup is being borrowed to install the dash app's dependencies, but the dash app is not part of the penn_chime module.

At the end of the day, the src directory should not be required to run anything.

Alternatively, pull the dash app into its own project and repo.