CodeForPhilly / chime

COVID-19 Hospital Impact Model for Epidemics

https://codeforphilly.github.io/chime/

MIT License

205 stars 151 forks source link

#358 Add tests for the cli #554

Closed unterwegerK closed 4 years ago

unterwegerK commented 4 years ago

Link to issue

Add tests for the cli Fixes: #358

Changelog entry

Added unit tests to run simulation via CLI
- Smoke test with doubling-time
- Smoke test with date-first-hospitalized
- Negative test if neither doubling-time nor date-first-hospitalized are defined
- Integration test to run a five-day simulation and verify the results.

Additional info

Functionality of method main in module cli has been has been extracted to a method run in order to support testing by injecting custom arguments.
The integration test uses the system date as current date and does not define the current-date argument. This is due to the fact that even with current-date the system date has an impact on the results.

Pull Request Checklist

For Reviewer

[ ] Submitted under the correct tag
[x] Runs without error or warning
[x] Documentation revised / included
[x] Unit tests included
[x] Issues referenced
[ ] Does not create new bugs / issues

unterwegerK commented 4 years ago

Wow, thanks for the fast review. I added a commit to adapt the naming style for the test methods.