CodeForPhilly / chime

COVID-19 Hospital Impact Model for Epidemics
https://codeforphilly.github.io/chime/
MIT License
205 stars 151 forks source link

[DevOps] Elastic APM #580

Open turnUpTheChill opened 4 years ago

turnUpTheChill commented 4 years ago

https://github.com/CodeForPhilly/chime/issues/566

Changelog entry

Added annotations and alterations to methods to allow them to be instrumented with Elastic APM. There is additional functionality like error message logging, which can be added but this gets the base line instrumentation and metrics

Additional info

Pull Request Checklist

For Reviewer

turnUpTheChill commented 4 years ago

@jlubken That should be possible, let me see how I can accomplish that.

We also have adocker-compose.yml file that can allow for a local monitoring stack to be deployed a long side the local app. I can provide instructions for that if it sounds like something that would be useful

turnUpTheChill commented 4 years ago

@jlubken It looks like the capability to do this will be available in a future release with an environment variable. If you want it sooner than that, I could try and do something with the logging object https://github.com/elastic/apm-agent-python/pull/790

turnUpTheChill commented 4 years ago

@jlubken I have added the configuration to disable APM locally. Should resolve that issue.

I can add some instructions and methods in case Developers do want to run APM locally so they can test out different instrumentation options. Let me know what sounds best to you.

cc: @MooseQuest