CodeForPhilly / clean-and-green-philly

Dashboard to target Philly vacant properties for anti-gun violence interventions
https://www.cleanandgreenphilly.org/
MIT License
31 stars 63 forks source link

A11y: Label property detail tables with unique names #362

Closed bacitracin closed 8 months ago

bacitracin commented 8 months ago

Describe the task

Currently the two tables on the property detail page do not have names or descriptions. Before they enter the content of the table, screenreader users just hear:

Tables 2 columns, 3 rows 2 columns, 8 rows

Name these tables by adding a caption for each table OR by adding an aria-label to each table tag. TBD on best title for each table.

This ticket is referring to the SinglePropertyDetail file

Acceptance Criteria

Tables Stats 2 columns, 3 rows Parcel details 2 columns, 8 rows

Additional context

More info:

Screenshot 2024-02-29 at 10 37 34 PM
Amberroseweeks commented 8 months ago

Hi i'd like to assign myself this issue. I think just adding the aria-label would work, I tested this using VO and I am able to hear the unique names for each table. I tested out aria-label="Community Impact" for the first table and aria-label="Land Information" for the second.

Screen Shot 2024-03-10 at 4 34 45 PM
nlebovits commented 8 months ago

Assigned! Thanks for tackling it :)