Bug: CSS warning on property detail

CodeForPhilly / clean-and-green-philly

Dashboard to target Philly vacant properties for anti-gun violence interventions

https://www.cleanandgreenphilly.org/

MIT License

32 stars 58 forks source link

Bug: CSS warning on property detail #573

Closed brandonfcohen1 closed 4 months ago

brandonfcohen1 commented 4 months ago

Describe the bug When navigating to a property, there is a CSS warning:

app-index.js:35 Warning: Invalid DOM property `fill-rule`. Did you mean `fillRule`?
    at path
    at svg
    at Rake
    at div
    at div
    at Card
    at PropertyAccessOptionCard

To Reproduce Steps to reproduce the behavior:

Go to http://localhost:3000/find-properties/452018920
Open console

Expected behavior No errors or warnings

Screenshots

paulhchoi commented 4 months ago

@brandonfcohen1 great catch, i think this will be handled with the linting pr i just put up with the changes at : https://github.com/CodeForPhilly/vacant-lots-proj/pull/574/commits/7e7e5d4b0252e264316c5f8e0c0da24a9bcef6ca#diff-e91c7f6274e6da4321a7c1355140df675b7808d833dd94ec188b93fb087a0d35L10-R17. testing locally with the PR doesn't show the warning either

brandonfcohen1 commented 4 months ago

yep, looks good on staging, will close