CodeForPhilly / clean-and-green-philly

Dashboard to target Philly vacant properties for anti-gun violence interventions
https://www.cleanandgreenphilly.org/
MIT License
32 stars 58 forks source link

Bug: Merged PRs fail to deploy to Vercel #822

Closed CodeWritingCow closed 2 months ago

CodeWritingCow commented 2 months ago

Describe the bug PRs are failing to deploy to Vercel's preview and production environments. The last successful deployment to production was PR #807 on July 19, 2024, at 11:11 a.m.

To Reproduce Steps to reproduce the behavior:

  1. Submit and merge a PR from a test branch to staging branch
  2. Submit and merge a PR from staging to main branch
  3. Verify that merged code fails to deploy to production

Expected behavior Vercel should successfully deploy PRs to production.

Screenshots @brandonfcohen1 shared a log showing a Vercel build failure due to TypeScript errors. See comments section.

Additional context This problem began on July 19, 2024, after new GitHub Actions were added to our repo's Workflow. Some possible causes suggested by Nissim and Brandon:

CodeWritingCow commented 2 months ago

Below is a snippet of the error log shared by Brandon:

Creating an optimized production build ...
 Compiled successfully
Linting and checking validity of types ...
Failed to compile.

./src/app/find-properties/[[...opa_id]]/page.tsx
11:10  Error: 'FilterProvider' is defined but never used.  @typescript-eslint/no-unused-vars

/src/components/ContentCard.tsx
1:14  Error: 'ReactNode' is defined but never used.  @typescript-eslint/no-unused-vars
37:3  Error: 'description' is defined but never used.  @typescript-eslint/no-unused-vars
38:3  Error: 'linkurl' is defined but never used.  @typescript-eslint/no-unused-vars
CodeWritingCow commented 2 months ago

It turns out there were two causes:

Both problems have been resolved.