A11y: Footer: Cookie Settings not keyboard accessible

CodeForPhilly / clean-and-green-philly

Dashboard to target Philly vacant properties for anti-gun violence interventions

https://www.cleanandgreenphilly.org/

MIT License

33 stars 65 forks source link

A11y: Footer: Cookie Settings not keyboard accessible #859

Open bacitracin opened 3 months ago

bacitracin commented 3 months ago

Describe the task

Currently the "Cookie Settings" in the footer is not reachable or operable via keyboard navigation (pressing TAB). That's because it's an a element with no href. Might make more sense to be coded as a button since it triggers the cookies popup.

Acceptance Criteria

[ ] You should be able to TAB to the Cookie Settings.
[ ] You should be able to activate Cookie Settings and make the popup show by pressing ENTER or SPACE buttons.
[ ] The Cookie Settings should still work when using screenreader.

Additional context

When the cookies popup shows, the focus should move to "Can we store cookies to your browser?" but I think that's outside the scope of this ticket.

Amberroseweeks commented 2 months ago

Hello! I'd like to be assigned this task if it is still open. Thank you

bacitracin commented 2 months ago

assigned!

github-actions[bot] commented 1 month ago

This issue has been marked as stale because it has been open for 30 days with no activity.

nlebovits commented 1 month ago

@bacitracin this ticket is stale. Does it need to be refined/rewritten?

bacitracin commented 1 month ago

@nlebovits the issue is still accurate, thanks for checking!

Amberroseweeks commented 1 month ago

Hi @bacitracin, Sorry for the delay, I have some time this week and next week to work on this. I will pick this up today if it's still open and ready to be worked on.

bacitracin commented 1 month ago

@Amberroseweeks No worries! I'll assign you

github-actions[bot] commented 6 days ago

This issue has been marked as stale because it has been open for 30 days with no activity.