search

CodeForPhilly / jawn

'Git for Tabular Data'
http://datjawn.com
BSD 3-Clause "New" or "Revised" License
44 stars 9 forks source link

Csv reader #21

Open benjaminettori opened 8 years ago

benjaminettori commented 8 years ago

Hi,

I took at stab at the csv to json reader. Not sure if this is what we are trying to do.

Also, I am having trouble integrating tape with travis-ci. The build fails and so does npm test. However if I run the tests locally they all pass. Any ideas?

mels065 commented 8 years ago

Hey Ben,

I think the issue might be that your JavaScript isn't standardized. I had the same problem as well.

Here's a link for how to format JavaScript:

http://standardjs.com/rules.html

benjaminettori commented 8 years ago

Hi thanks for the link. I think it's weird that travis enforces no semicolons at the end of the line. I used to work with lint, and it enforced the exact opposite rule!

mels065 commented 8 years ago

Haha yeah I know! I'm so used to using semicolons.

flyingzumwalt commented 8 years ago

Travis is running both standardjs and travis. Here are the details for your build: https://travis-ci.org/CfABrigadePhiladelphia/jawn/jobs/113008574

It's failing with some style complaints from standardjs.

flyingzumwalt commented 8 years ago

Oops. Didn't see your comments!

I bet we can change the settings for standardjs if we have our own style preferences, or we could just turn it off.