search

CodeForPhilly / jawn

'Git for Tabular Data'
http://datjawn.com
BSD 3-Clause "New" or "Revised" License
44 stars 9 forks source link

Return stream from import.js #36

Closed benjaminettori closed 8 years ago

flyingzumwalt commented 8 years ago

:+1: I like this approach better than using miss.pipe. The code in the test looks much more like what we wanted to write initially. I think the main thing that tripped us up before (other than not really understanding streams) was that we wrote our test to listen for an end event when it needed to listen for finish events like you did in line 16 of test/import.js

@wtkm7 do you have opinions on this? Want to merge it?

flyingzumwalt commented 8 years ago

@benjaminettori It looks like there are a bunch of extra commits on this PR's branch. Do you know why they're showing up?

benjaminettori commented 8 years ago

@flyingzumwalt I think they are showing up because I had to rebase my repo when getting the latest commits from the main repo.

flyingzumwalt commented 8 years ago

Could you squash the commits down to one with a message like use miss.pipeline to return a stream?

mels065 commented 8 years ago

:+1: @benjaminettori I'm ready to merge this once you've squashed down the commits

benjaminettori commented 8 years ago

@mels065 Ok I have squashed the commits as much as I can. It may be possible to squash them further after the merge.