search

CodeForPhilly / prevention-point

Current Functional Product
MIT License
30 stars 15 forks source link

Fix participant list header on mobile #412

Closed MikeyManoguerra closed 4 years ago

MikeyManoguerra commented 4 years ago

This is my fault for not catching initially. currently the constant for header titles is: 


export const PARTICIPANT_LIST_TABLE_TITLES = [
  { value: true, title: "PPID" },
  { value: true, title: "First Name" },
...
]

however, in the map function PrevPointTableHead.js is destructuring 'mobile' as a key. since mobile is always undefined and thus falsy (there is no mobile key available, only value), the every header title get the css class that hide the table on mobile, per our ternary.

change the the name of the key from 'value' to 'mobile' for each of the objects in the PARTICIPANT_LIST_TABLE_TITLES array.

sxgormley commented 4 years ago

Hey, @dmjohnspor! How's this coming along?

the-fetaverse commented 4 years ago

Hello @sxgormley this issue is completed.