CodeForPittsburgh / food-access-data-transformation

Data Transformation Scripts for the Code For Pittsburgh Food Access Map
MIT License
2 stars 4 forks source link

Code cleanup! #1

Closed hellonewman closed 2 years ago

hellonewman commented 2 years ago

Matt is planning some code spring cleaning. This will help us improve the functionality and fix some bugs with filtering. @mishugana to add more details, he is hoping to start June 15, but anyone can jump in early!

maxachis commented 2 years ago

I've created a merge request that removes commented-out code in script.js. I think most of it is fairly intuitive to remove, but I'd like to make sure Matt et. al. have a look at what's being removed to confirm it's good to remove.

https://github.com/CodeForPittsburgh/CodeForPittsburgh.github.io/pull/33

maxachis commented 2 years ago

I created a second merge request that does some light refactoring on script.js, but more importantly moves files into their own respective folders. I tested my local version of the website to make sure everything was still working as intended, but it's probably a good idea if others have a look at it as well.

https://github.com/CodeForPittsburgh/CodeForPittsburgh.github.io/pull/34

maxachis commented 2 years ago

This one refactors the HTML page -- removing commented out code, rearranging some elements into a more logical order, and adding some informative comments to the Head section.

https://github.com/CodeForPittsburgh/CodeForPittsburgh.github.io/pull/35

maxachis commented 2 years ago

I'm making my way through a more significant refactoring of the code. I'm also going to drop this in here, because holy smokes we were not doing a lot of this.

https://www.bdo.com/digital/insights/application-development/5-tips-organize-javascript-without-framework

maxachis commented 2 years ago

https://github.com/CodeForPittsburgh/CodeForPittsburgh.github.io/pull/39

Here's the pull request. It's a substantial one, so I ask someone else have a look at this and do some testing to confirm that I'm not breaking anything.

hellonewman commented 2 years ago

move this

hellonewman commented 2 years ago

done!