search

CodeForPittsburgh / food-access-data-transformation

Data Transformation Scripts for the Code For Pittsburgh Food Access Map
MIT License
2 stars 4 forks source link

Bug: Labels not showing correctly in Results #3

Closed hellonewman closed 2 years ago

hellonewman commented 2 years ago

When selecting sites using the Radius tool, only SNAP and Fresh Produce show as labels in the results list even if sites have other food services available.

maxachis commented 2 years ago

This may or may not be related to the issues we are having where not all rows have a type set -- some of them are blank, where they should be other, or they should have a different type assignment than what they have.

We discuss this partly in this issue here: https://github.com/CodeForPittsburgh/food-access-map-data/issues/214

maxachis commented 2 years ago

Giovanni will also take a look at this!

gsvevo commented 2 years ago

On line 385 in script.js the condition after the if statement includes only SNAP, WIC and Food Bucks, To show the correct labels we need to add the missing categories (fresh produce and FMNP). Also, as @maxachis mentioned, not all rows on the csv data have a type set and some have null instead of 0.

hellonewman commented 2 years ago

move to new repo

maxachis commented 2 years ago

Mike says he's resolved this in his latest change! We'll work on pulling that next.

hellonewman commented 2 years ago

Fixd!