CodeForPittsburgh / food-access-data-transformation

Data Transformation Scripts for the Code For Pittsburgh Food Access Map
MIT License
2 stars 4 forks source link

Ensure website is mobile-friendly #6

Closed maxachis closed 2 years ago

maxachis commented 2 years ago

Most of our development has been done on desktop. It's entirely possible everything works well out of the box on mobile, but in either case we should check and confirm this.

runstache commented 2 years ago

One of the things that we might want to investigate is moving the navigation from the side to the top. When building things for mobile, it's normally best to keep things off the Left and Right of the screen to maximize the real estate of the map. We could move the navigation sections to the top using bootstrap and have the map be below for scrolling.

maxachis commented 2 years ago

We probably want to specify what changes we want, and compare them to how things look right now. Once we have a specific idea of how we want everything to look, it'll be easier for someone to work on it.

Here is the main page when configured for "IPad Air" image

Here's how it looks for "Samsung Galaxy S8" image

Here's how it looks for "iPhone SE" image

maxachis commented 2 years ago

There was a request to move the navigation buttons (plus, minus, arrow thingy) from top-right to bottom-right, and someone MIGHT have made those changes locally, but we don't have a pull request for that right now.

maxachis commented 2 years ago

Michael Feeney is getting close to done with this -- there's just a bug that needs to be fixed with how the lower bar appears. Here's how it looks right now!

image

And here is Mike's repository/branch: https://github.com/mike-feeney/CodeForPittsburgh.github.io/tree/mobile-debug

maxachis commented 2 years ago

Giovanni will also be helping out Mike with this!

maxachis commented 2 years ago

Mike says it's ready for production, although with one caveat:

Only issue is that the sidebar, while it opens smoothly, just closes abruptly when you collapse it. No immediately apparent easy way to solve this, but it's such a minor issue that trying to solve it is likely more trouble than it's worth.

hellonewman commented 2 years ago

all done!