search

CodeForPittsburgh / food-access-map-data

Data for the food access map
MIT License
8 stars 18 forks source link

BUG?: Source data not being updated after run.sh #163

Closed maxachis closed 2 years ago

maxachis commented 3 years ago

Wicresults.json should be updating each time run.sh is run but appears to have not been updated in 2 months: https://github.com/CodeForPittsburgh/food-access-map-data/tree/master/food-data/new-datasets

This appears to be because of an odd bug where, as far as I can tell, the APIs and everything are running properly, but the source data files aren't being committed and added to the Github during the run script. They're being generated, just not saved (at least I think that's what's happening).

hellonewman commented 3 years ago

reconfigure the YAML file.

hellonewman commented 2 years ago

The data is being pulled but not saved/committed? Need to add a couple lines to the YAML to overwrite wicresults.json with the new data.

maxachis commented 2 years ago

So we do know that the information wicresults.json draws from hasn't had new data for at least four months. So simply making sure the master branch updates the proper subfolder properly should do the trick, but it could be made a bit more efficient if we could add a timestamp to wicresults.json (the text of the file, not the filename itself) to indicate when it was most recently updated.

maxachis commented 2 years ago

I added to run.sh Matt's script that is supposed to create wicresults.json and add a timestamp to it, but at least right now that code doesn't appear to be yielding a wicresults.json file with a timestamp. Will need to get back to this later and revise the script.

maxachis commented 2 years ago

Issue resolved and closed.