search

CodeForPoznan / volontulo

Web portal for collaboration of community volunteers with organizations and institutions.
MIT License
12 stars 44 forks source link

[864] phone number validation - frontend #1064

Closed stanislawK closed 6 years ago

stanislawK commented 6 years ago

Description:

Add phone validation via IMask

codecov-io commented 6 years ago

Codecov Report

Merging #1064 into master will increase coverage by 0.07%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1064      +/-   ##
==========================================
+ Coverage   90.69%   90.77%   +0.07%     
==========================================
  Files         115      115              
  Lines        2731     2731              
  Branches       31       31              
==========================================
+ Hits         2477     2479       +2     
+ Misses        250      248       -2     
  Partials        4        4
Impacted Files Coverage Δ
...end/src/app/user-profile/user-profile.component.ts 68% <ø> (ø) :arrow_up:
frontend/src/app/auth.service.ts 96.82% <0%> (+3.17%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eb158a9...f2c3b6e. Read the comment docs.

juliaanholcer commented 6 years ago
  1. Are 61 856-56-46, 61 856 56 46, 61 8565646 61 856 5646 are valid or invalid phone number?
  2. Displayed error should indicate how the correct format looks like.
stanislawK commented 6 years ago 
1. Are 61 856-56-46, 61 856 56 46, 61 8565646 61 856 5646 are valid or invalid phone number?

2. Displayed error should indicate how the correct format looks like.

Ad.1 Landline phone numbers in formats listed by You, are invalid for now. Should we handle it also? If I wrote form test, it would pass codecov ?

juliaanholcer commented 6 years ago

I've already merge your PR so this fix needs to be done in another one, but I've also added new issue about organization-contact form and I think fix can be added there.