search

CodeForTheCaribbean / HarvestAPI

Agricultural API
MIT License
8 stars 4 forks source link

Why is 'id' not used as a primary key? #7

Open pui opened 10 years ago

pui commented 10 years ago

I'm just starting to dig through the code and I have a quick question. Why is 'id' not the default primary key for tables? It looks like there are some external ids being stored, but it's better if they're not used as an internal identifier. I also noticed that the farmers table uses farmer_id as a primary key. This is confusing, as _id is used to signify a foreign key.

varunity commented 10 years ago

Hey, @pui . Thanks for taking a look. Luckily we are in an early enough stage with the API that we can still make these types of (design)changes. I think we can move towards using 'id' for primary keys and '_id' for foreign keys. Please let me know if you have any other quick questions. I'll work this API design suggestion into the next API version.

paradoxxjm commented 10 years ago

Hey @varunity,

Is the DB table schema that was created in GDocs up-to-date? It might be a good idea to share that so @pui can see the fields and their description.

-MMM

On Tue, Jul 22, 2014 at 2:20 PM, varunity notifications@github.com wrote:

Hey, @pui https://github.com/pui . Thanks for taking a look. Luckily we are in an early enough stage with the API that we can still make these types of (design)changes. I think we can move towards using 'id' for primary keys and '_id' for foreign keys. Please let me know if you have any other quick questions. I'll work this API design suggestion into the next API version.

— Reply to this email directly or view it on GitHub https://github.com/CodeForTheCaribbean/HarvestAPI/issues/7#issuecomment-49737387 .

Best Regards, Matthew McNaughton

pui commented 10 years ago

Just FYI, I'm digging through the code. It would also be great to see any further documentation too.