CodeGrade / bottlenose

CS assignment / grade mangement system
GNU Affero General Public License v3.0
38 stars 21 forks source link

Existing teams will not disconnect when a member drops when end date != nill #144

Open grobalex opened 5 years ago

grobalex commented 5 years ago

app/models/teamset.rb line 84 has a deliberate debugger statement because it sits inside a situation that is logically inconsistent: an active team with a student that has dropped the course. After further diagnostics with Matt this afternoon, I think we found the issue. Withdrawing from a course will disconnect from existing teams...but it only does so for teams that have nil end date (since that's how we detect active teams). But that's an underapproximation. Any teams with an end date in the future is also active. So we should fix disconnect to be more aggressive about dissolving teams, and we should change this debugger to give a more informative error...