search

CodeGrade / bottlenose

CS assignment / grade mangement system
GNU Affero General Public License v3.0
38 stars 21 forks source link

Unicode in code submissions? #174

Open nicholas-miklaucic opened 4 years ago

nicholas-miklaucic commented 4 years ago

The grader currently errors when you try to use non-ASCII characters in code submissions.

image

Obviously this isn't a priority, but it'd be nice to have full Unicode support (or at least extended Latin-1 support) in code submissions for supporting the full set of text in English and other languages.

blerner commented 4 years ago

Hmm, not sure whether I have control over that. I suspect it's a bug in one of the underlying style checkers I use, and their ability to parse Java might not be 100% identical to the actual Java spec.

nicholas-miklaucic commented 4 years ago

Interesting: I guess it'll have to stay the way it is.

blerner commented 4 years ago

https://checkstyle.org/writingchecks.html#Limitations

blerner commented 4 years ago

Specifically, it'll handle Unicode characters in string literals, but it won't handle them for Java identifiers. https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/com/puppycrawl/tools/checkstyle/grammar/javadoc/JavadocLexer.g4#L267-L269 shows where the tool attempts to recognize Java identifiers, and it...does not do a very precise job of it.

nicholas-miklaucic commented 4 years ago

Yeah.. that isn't the most precise way of doing things.

On Sun, Feb 23, 2020 at 10:02 PM Ben Lerner notifications@github.com wrote:

Specifically, it'll handle Unicode characters in string literals, but it won't handle them for Java identifiers. https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/com/puppycrawl/tools/checkstyle/grammar/javadoc/JavadocLexer.g4#L267-L269 shows where the tool attempts to recognize Java identifiers, and it...does not do a very precise job of it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/CodeGrade/bottlenose/issues/174?email_source=notifications&email_token=AGJMH4INPGS7DOUFNKSCMXTREM2D7A5CNFSM4K2ACDEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMWQJDI#issuecomment-590152845, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGJMH4M2DEW7HBQCOSHHN53REM2D7ANCNFSM4K2ACDEA .

blerner commented 4 years ago

I've filed https://github.com/checkstyle/checkstyle/issues/8050, but I'm not optimistic for a positive response.

nicholas-miklaucic commented 4 years ago

Thanks for trying.