User method disconnect now finds active teams with and without an end…

CodeGrade / bottlenose

CS assignment / grade mangement system

GNU Affero General Public License v3.0

37 stars 21 forks source link

User method disconnect now finds active teams with and without an end… #224

Closed williams-jack closed 2 years ago

williams-jack commented 2 years ago

… date.

Just need to go over the debugger statement on line 84 in app/models/teamset.rb.

This is a fix for #144.

williams-jack commented 2 years ago

Should be ready to go. Take a look at lines 239 & 240 at app/models/assignment.rb (under Files Changed) for a section to look for feedback/a potential edit for.

blerner commented 2 years ago

Needs regression tests to confirm that the old buggy behavior is now resolved: teamsets can't be duped if there are invalid teams in them; no active teams should exist with a student that dropped the course.