CodeGrade / bottlenose

CS assignment / grade mangement system
GNU Affero General Public License v3.0
38 stars 21 forks source link

Fix: Race Condition on Test Deleting Upload Path #283

Closed williams-jack closed 2 months ago

williams-jack commented 2 months ago

When the FilesController test is not the first test to run, The teardown was attempting to remove the upload dir while files from the previous tests that utilized Upload populated that directory, thus causing a directory not empty error.

blerner commented 2 months ago

So this failed too, because now if your tests run first, the uploads directory doesn't exist yet!