Relative path support (markdown)

afterthat97 commented 5 years ago

the current version doesn't support relative path in markdown. for example, ![](./image.jpg) cannot load the image, but GitHub website and many markdown apps can.

sukie-sun commented 5 years ago

many markdown apps can？？for example。。。。。。。

发送自 Windows 10 版邮件应用

发件人: Alfred Liu 发送时间: 2019年4月22日 19:41 收件人: CodeHubApp/CodeHub 抄送: Subscribed 主题: [CodeHubApp/CodeHub] Relative path support (markdown) (#585)

the current version doesn't support relative path in markdown. for example, cannot load the image, but GitHub website and many markdown apps can. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

afterthat97 commented 5 years ago

macDown (a markdown app for mac) typora ( u must know this)

On Mon, Apr 22, 2019 at 20:16 sungithub notifications@github.com wrote:

many markdown apps can？？for example。。。。。。。

发送自 Windows 10 版邮件应用

发件人: Alfred Liu 发送时间: 2019年4月22日 19:41 收件人: CodeHubApp/CodeHub 抄送: Subscribed 主题: [CodeHubApp/CodeHub] Relative path support (markdown) (#585)

the current version doesn't support relative path in markdown. for example, cannot load the image, but GitHub website and many markdown apps can. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/CodeHubApp/CodeHub/issues/585#issuecomment-485403358, or mute the thread https://github.com/notifications/unsubscribe-auth/AF6CBDDPPMXGC4GPOVD2USTPRWUCNANCNFSM4HHPFW6A .

pk23488 commented 5 years ago

please make offer for one not all

发自我的iPhone

------------------ Original ------------------ From: Alfred Liu notifications@github.com Date: Mon,Apr 22,2019 8:23 PM To: CodeHubApp/CodeHub CodeHub@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: Re: [CodeHubApp/CodeHub] Relative path support (markdown) (#585)

macDown (a markdown app for mac) typora ( u must know this)

On Mon, Apr 22, 2019 at 20:16 sungithub notifications@github.com wrote:

many markdown apps can？？for example。。。。。。。

发送自 Windows 10 版邮件应用

发件人: Alfred Liu 发送时间: 2019年4月22日 19:41 收件人: CodeHubApp/CodeHub 抄送: Subscribed 主题: [CodeHubApp/CodeHub] Relative path support (markdown) (#585)

the current version doesn't support relative path in markdown. for example, cannot load the image, but GitHub website and many markdown apps can. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/CodeHubApp/CodeHub/issues/585#issuecomment-485403358, or mute the thread https://github.com/notifications/unsubscribe-auth/AF6CBDDPPMXGC4GPOVD2USTPRWUCNANCNFSM4HHPFW6A .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

sukie-sun commented 5 years ago

I know about typora，but I think it does’t recommend use typora with relative path，

发送自 Windows 10 版邮件应用

发件人: Feixu_Yan 发送时间: 2019年4月22日 20:30 收件人: CodeHubApp/CodeHub 抄送: sungithub; Comment 主题: Re: [CodeHubApp/CodeHub] Relative path support (markdown) (#585)

please make offer for one not all

发自我的iPhone

------------------ Original ------------------ From: Alfred Liu notifications@github.com Date: Mon,Apr 22,2019 8:23 PM To: CodeHubApp/CodeHub CodeHub@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: Re: [CodeHubApp/CodeHub] Relative path support (markdown) (#585)

macDown (a markdown app for mac) typora ( u must know this)

On Mon, Apr 22, 2019 at 20:16 sungithub notifications@github.com wrote:

many markdown apps can？？for example。。。。。。。

发送自 Windows 10 版邮件应用

发件人: Alfred Liu 发送时间: 2019年4月22日 19:41 收件人: CodeHubApp/CodeHub 抄送: Subscribed 主题: [CodeHubApp/CodeHub] Relative path support (markdown) (#585)

the current version doesn't support relative path in markdown. for example, cannot load the image, but GitHub website and many markdown apps can. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/CodeHubApp/CodeHub/issues/585#issuecomment-485403358, or mute the thread https://github.com/notifications/unsubscribe-auth/AF6CBDDPPMXGC4GPOVD2USTPRWUCNANCNFSM4HHPFW6A .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

afterthat97 commented 5 years ago

But many github repos use relative links in README.md to load images in the same repo, and github parses this well in browser. So I wish that this feature can be implemented.

joonaspaakko commented 5 years ago

Hasn't this topic veered off course? It doesn't matter what apps support relative paths. Github has had relative paths for about 6 years, I believe. It's probably not just a phase. If CodeHub is supposed to support Github, it seems like a good enough reason to write support for it too, right?

afterthat97 commented 5 years ago

Hasn't this topic veered off course? It doesn't matter what apps support relative paths. Github has had relative paths for about 6 years, I believe. It's probably not just a phase. If CodeHub is supposed to support Github, it seems like a good enough reason to write support for it too, right?

That's exactly what I want to say.

CodeHubApp / CodeHub

Relative path support (markdown) #585