search

CodeHubApp / CodeHub

CodeHub is an iOS application written using Xamarin
http://www.codehub-app.com
22.82k stars 615 forks source link

Fixes scroll when viewing Markdown files #664

Closed bibstha closed 4 years ago

bibstha commented 4 years ago

Fixes #654 #651 #650 #632 #613

Due to the overflow: hidden, when you open a Readme.md or any other markdown file on iOS, it scrolling is completely disabled.

With this, you should be able to scroll again!

Screenshot: https://drive.google.com/open?id=1y4OAwe2qyTG1ATHT7upZiZTnjjxFHNXx cc: @thedillonb

spacebahr commented 4 years ago

Thanks I have been trying see what issues other people are having with the ras pi

On Sun, Apr 19, 2020 at 11:51 PM Bibek Shrestha notifications@github.com wrote:

Fixes #651 https://github.com/CodeHubApp/CodeHub/issues/651 #650 https://github.com/CodeHubApp/CodeHub/issues/650 #632 https://github.com/CodeHubApp/CodeHub/issues/632 #613 https://github.com/CodeHubApp/CodeHub/issues/613

Due to the overflow: hidden, when you open a Readme.md or any other markdown file on iOS, it scrolling is completely disabled.

With this, you should be able to scroll again!

You can view, comment on, or merge this pull request online at:

https://github.com/CodeHubApp/CodeHub/pull/664 Commit Summary

  • Fixes scroll when viewing Markdown files

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/CodeHubApp/CodeHub/pull/664, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOX44A2YBHH3RUEVOC4CYHDRNPBFZANCNFSM4MMC67VA .

Faroop commented 4 years ago

Nope still doesn’t allow for scrolling.

mocarvalhomoc commented 4 years ago

Replay what??

Marcelo Carvalho Em 21 de abr de 2020 02:25 -0300, Faraz notifications@github.com escreveu:

Nope still doesn’t allow for scrolling. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

bibstha commented 4 years ago

Did you try compiling the changes and loading it on a simulator or your iPhone? Please don’t confuse this with the released app version on App Store. I’m waiting for the maintainer to test and merge and then release the patch.

fasm commented 4 years ago

Good luck. This app hasn’t received an update in a year. The author/maintainer of the App Store app is MIA.

thedillonb commented 4 years ago

Outstanding work @bibstha! I will work to produce a new image for the app store. Thank you for your contribution!

bibstha commented 4 years ago

Hi @thedillonb any chance of a new release soon? I use it to read and write my notes and this fix will make the experience much better.

thedillonb commented 4 years ago

@bibstha yes. It's actually in progress right now. There was an issue with the GitHub account I traditionally give to Apple to use in reviewing the application.

jpinkham commented 4 years ago

I can confirm that the scrolling issue is now resolved! Download the latest version from the App Store (with a nice shoutout to @bibstha in release description), v2.19.1, which was released about a week ago. Thank you thank you thank you 😍