search

CodeHubOrg / javascript101

:earth_africa: Website for the javascript101 meetup Bristol
http://javascript101.co.uk
1 stars 10 forks source link

Add Sponsors to Home Page #40

Closed rinse0ut closed 7 years ago

rinse0ut commented 7 years ago

As per https://www.meetup.com/CodeHub-Bristol/

trianah commented 7 years ago

@rinse0ut I added the sponsors to the home page but accidentally pushed my branch to upstream (oops)

rinse0ut commented 7 years ago

@trianah Great, well done thanks. I've noticed you have created a new sponsors mixin which duplicates the functionality of the logoList mixin without the responsive classes. Please could you use the logoList mixin instead (so that we keep things DRY) and remove the sponsors mixin. You might have to add an extra parameter for the css class name to the LogoList mixin.

Once that's done please make a pull request. Please delete your branch from upstream. (git push updstream --delete sponsors)

rinse0ut commented 7 years ago

Please move the sponsors section to above the 'How to contribute' section.

rinse0ut commented 7 years ago

Closing as per our discussion about formatting at the hack night.