search

CodeIgniter / coding-standard

Official Coding Standards for CodeIgniter
MIT License
65 stars 9 forks source link

Test failure #5

Closed kenjis closed 2 years ago

kenjis commented 2 years ago 
There was 1 failure:

1) CodeIgniter\CodingStandard\Tests\CodeIgniter4Test::testAllBuiltInFixersNotDeprecatedAreConfiguredInThisRuleset
[CodeIgniter4 Coding Standards] Non-deprecated built-in fixer "no_useless_concat_operator" is not configured in the ruleset.
Failed asserting that an array is empty.

/home/runner/work/coding-standard/coding-standard/vendor/nexusphp/cs-config/src/Test/AbstractRulesetTestCase.php:105

--

There was 1 skipped test:

1) CodeIgniter\CodingStandard\Tests\CodeIgniter4Test::testEnabledConfigurableFixerUsesAllAvailableOptionsNotDeprecated with data set "no_useless_concat_operator" ('no_useless_concat_operator', array('juggle_simple_strings'), array())
`no_useless_concat_operator` is not yet defined in this ruleset.

/home/runner/work/coding-standard/coding-standard/vendor/nexusphp/cs-config/src/Test/AbstractRulesetTestCase.php:185

https://github.com/CodeIgniter/coding-standard/actions/runs/3243787612/jobs/5319015475

MGatner commented 2 years ago

@paulbalandan do you know? I can look into it if not.

paulbalandan commented 2 years ago

This is from v3.12. Once https://github.com/codeigniter4/CodeIgniter4/pull/6678 is in, I can add the rule here.