CodeLionX / actordb

Actor Database System Framework using Akka
MIT License
0 stars 2 forks source link

Add RowRelationTest #31

Closed srfc closed 6 years ago

srfc commented 6 years ago

Proposed Changes

Related

srfc commented 6 years ago

Tests for insertions should work as soon as the change to the Relation.insert interface has been merged, and this feature branch rebased onto those changes.

With regard to the failed tests here to issues are apparent:

I think the latter two, are bugs that should be fixed. What do you think of insertAll returning a Try analogously to insert?

CodeLionX commented 6 years ago

Can you already work on the mentioned issues for when? Otherwise, I would suggest creating issues for that, so we can merge this PR anyway.

Regarding insertAll, I'm totally fine with also changing its return type to Try[Seq[Record]], but then we should make clear its semantics. I would prefer it to be an atomic operation (this will need some more logic, but should be possible).

srfc commented 6 years ago

W.r.t. the two bugs, i.e. whereAll queries failing on missing values and where not being able to match on an empty field I will need some time to fix.

I will create issues for all three cases and ignore the failing test cases so that we can merge.

I will open a new PR to change the return type of Relation.insertAll, after this and the Relation.insert change being merged, these tests should then run fine.

CodeLionX commented 6 years ago

Please mark the test as pending instead of ignoring it.

Thanks for all the issues: #35, #36, #37, #34