CodeMyst / deezcord

deezer Discord Rich Presence - Show your deezer status in Discord.
MIT License
16 stars 5 forks source link

Rich Presence doesn't work anymore #6

Open b1sergiu opened 4 years ago

b1sergiu commented 4 years ago

Hey there, the Rich Presence API that you're using is deprecated and no longer works.

I forked your project and fixed the issue by using Lachee's API. Maybe we should consider merging sometime?

Thanks

b1sergiu commented 4 years ago

@CodeMyst don't know if you'll see this so I'm mentioning you

CodeMyst commented 4 years ago

Thanks for mentioning me, otherwise I wouldn't have seen it. It's awesome that you forked my project and you improved it. My version had a lot of issues.

I would be very open to merging and would like to contribute some code if needed as well. Tomorrow I'll check out your project and we can go from there. Do you have any ideas on how we should merge the projects into one?

b1sergiu commented 4 years ago

We could keep Avalonia however I don't know how it works or how to update it properly. I'm currently planning to change the Deezer API since the old one seems to throw an SSL error after you use it for 20-30 minutes.

CodeMyst commented 4 years ago

Huh I didn't notice that with the API before. Unfortunately that's the only one you can use.

Also I'll look into some other UI options and check Avalonia again, in the current repo Avalonia doesn't work on some machines for some reason.

b1sergiu commented 4 years ago

Unfortunately that's the only one you can use.

What about E.Deezer?

CodeMyst commented 4 years ago

From the looks of it, it's just a wrapper around the official Deezer API.

b1sergiu commented 4 years ago

Might fix the issue, you never know lol

CodeMyst commented 4 years ago

I'll try reproducing the issue you had first.

b1sergiu commented 4 years ago

I can fix the code and you could add a proper UI and we could merge those in a future Deezcord 2.0 update. What do you think?

CodeMyst commented 4 years ago

fine by me!

-------- Original message -------- From: Sergiu Bucur notifications@github.com Date: 13/04/2020 22:58 (GMT+01:00) To: CodeMyst/deezcord deezcord@noreply.github.com Cc: CodeMyst codemyst@outlook.com, State change state_change@noreply.github.com Subject: Re: [CodeMyst/deezcord] Rich Presence doesn't work anymore (#6)

I can fix the code and you could add a proper UI and we could merge those in a future Deezcord 2.0 update. What do you think?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/CodeMyst/deezcord/issues/6#issuecomment-613094829, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB4Y7JGSCEMYQ2XXEFJDCHDRMN4H5ANCNFSM4METHMEA.

CodeMyst commented 4 years ago

@b1sergiu I made a basic avalonia app in the v2 branch, could you submit a PR with your code into it and i'll hook it up?

b1sergiu commented 4 years ago

I'm not yet ready, I'll try to finish the project tomorrow. I had to contact the E.Deezer developer and it took a long time

CodeMyst commented 4 years ago

Hmm okay, I'm still pretty certain we don't need an api wrapper like E.Deezer but I'll do some tests tomorrow.

b1sergiu commented 4 years ago

Hey, I don't think I'm going to use E.Deezer anymore. I find it hard to use and it's barely documented at all. Should I just leave the old API as is?

CodeMyst commented 4 years ago

Sure

b1sergiu commented 4 years ago

Hey, I'm back. Sorry for the wait. I will update the code and issue a pull request.

b1sergiu commented 4 years ago

Done. Here it is

CodeMyst commented 4 years ago

will check the PR tomorrow if i can!

-------- Original message -------- From: Sergiu Bucur notifications@github.com Date: 13/05/2020 22:39 (GMT+01:00) To: CodeMyst/deezcord deezcord@noreply.github.com Cc: CodeMyst codemyst@outlook.com, State change state_change@noreply.github.com Subject: Re: [CodeMyst/deezcord] Rich Presence doesn't work anymore (#6)

Done. Here it ishttps://github.com/CodeMyst/deezcord/pull/7

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/CodeMyst/deezcord/issues/6#issuecomment-628233793, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB4Y7JEK7DMSD3FISMZQS7TRRMARHANCNFSM4METHMEA.

CodeMyst commented 4 years ago

also, from a quick glance, it seems you leaked your api keys... :/

b1sergiu commented 4 years ago

...fuck my life