search

CodeOptimist / rimworld-while-youre-up

While You're Up mod for RimWorld. Uses my library: https://github.com/CodeOptimist/rimworld-codeoptimist-library
https://steamcommunity.com/sharedfiles/filedetails/?id=2034960453
GNU Affero General Public License v3.0
4 stars 2 forks source link

Initial attempt to update to modern steam version #11

Open marr75 opened 1 year ago

marr75 commented 1 year ago

I don't expect that you'll accept this PR because you have access to the original source but I was debugging my game and some errors from While You're Up/PUAH+ (JobsOfOpportunity) and realized the source of the steam version still wasn't available in the steam download or this github repo so I made a "homebrew update" of the source and submitted it.

I'm hoping that whatever the delay in updating the repo from last time we talked, seeing a PR with the full, modern source in a buildable format pieced together from the github repo source and the assemblies helps you overcome whatever barrier has been keeping you from posting it.

It seems like you have a private repo with the CodeOptimist namespace somewhere. I can see how that might not be GNU like the JOO is and how you might not want to duplicate that code in this repo. My top proposal would be that you incorporate the source using a git submodule (i.e. commit that source to github but under a copyright/all rights reserve license and then link it as a submodule). My second proposal would be that you include the CodeOptimist utilities in this repo in binary form (if you don't want to release the source) and have the ILRepack operate on the binary in this repo. Either way, other devs will be able to build this repo from the source at least. You could also distribute it on steam (and nuget) separately and get rid of ILRepack altogether (which would be nice!).

CodeOptimist commented 1 year ago

I'm sorry about that Matt. It's not intentional. While You're Up has a final 4.0.0 update that will be released soon (it's been finished for a month, actually). Entirely fixes and code clarity improvements. Then I'm probably retiring from RimWorld. I've completely forgotten that this repo was never updated with even the older versions.

Also a major part of the new 4.0.0 version is I went through the source code top to bottom, making it absolutely as clear as I possibly could, improving the architecture, adding comments, etc. as my parting act. I promise the repo will be fully updated along with the release. And the CodeOptimist library (that was never intended to be private either).