search

CodePanter / another-bronzeman-mode

A runelite plugin implementation for the Bronzeman mode.
BSD 2-Clause "Simplified" License
7 stars 6 forks source link

Fixed name and current chat channel display in chatbox #18

Closed nblackley closed 2 months ago

nblackley commented 2 months ago

When the plugin adds the Bronzeman icon to the chatbox name, it overrides everything before the : in the chatbox. This includes the current chat channel that gets displayed if the Chatbox Mode - Set Automatically setting is enabled from the in-game settings.

What the default chatbox name looks like without the plugin enabled image

When you enable the plugin, it overrides the chatbox name as shown: image

This PR fixes this behavior by getting the full name text, including current chat channel, then appending the bronzeman icon to that. New behavior: image

CodePanter commented 2 months ago

Hey there! I never knew there was a 'current chat channel' feature like that! Thank you for fixing this! I would be happy to merge this change, but do have one request for you. Would you mind making the default/fallback be just the player name? That would mean that if 'chatboxInput' is null for some reason, or idx return -1, we still show the player name instead of an empty string.

nblackley commented 2 months ago

Yeah good call. Just made the change and thanks for the reply! Really enjoying the plugin!

CodePanter commented 2 months ago

Awesome, thank you very much! Glad to hear the plugin is working well for you! I have a bug report I want to fix tomorrow. if that goes well; I'll merge your code and that fix together and push it off to the plugin hub!

CodePanter commented 2 months ago

This has been merged, and will be available in the game as soon as the pull request for the plugin hub is accepted here: https://github.com/runelite/plugin-hub/pull/6302

CodePanter commented 1 month ago

This fix is now live in the plugin hub. Thanks again for fixing this!