CodeReadingClubs / annotation-tool

https://annotate.codereading.club
MIT License
22 stars 1 forks source link

Annotation tool doesn't render large code files. #13

Open NathanFrasier opened 2 years ago

NathanFrasier commented 2 years ago

I'm trying to start a code reading club for Rust code, And wanted to focus on the rust stdlib. Much of the rust stdlib has huge files, and the code annotation tool doesn't seem to render anything past 1000 lines.

example link here: https://annotate.code-reading.org/#/file/E4VwzgLgtANghgOwOYHpSRQIxge0ygFgAYCBjADgIHYBGOTOANiNICYATcgZioDM4qrcgFMqpQQE44RXgFYOs7kRQwAlpmBxgATxSkcwYSjDBSe4TBgA6YGCA

katjam commented 2 years ago

Thanks for letting us know. I've seen this in chrome. Which browser & platform are you on?

As a temporary potential workaround... I can get the full file to load in firefox.

danfishgold commented 2 years ago

it's working for me but with substantial lag. unfortunately I didn't optimize it for large files, partly because I built it with small-ish files in mind (around 100 lines of code)

right now I'm working on making long arrows easier to draw and I'm happy to use the opportunity to optimize it for 1000+ lines of code 😄 (although at that scale I think you'd probably need different tools that aren't a priority for our use case, for example a minimap or code folding)

NathanFrasier commented 2 years ago

I can confirm that the Firefox workaround is working. I plan on looking into better tooling as time moves on, but for our first session I was planning to keep things pretty basic.

This issue was seen in Chrome version is 95.0.4638.69 on Windows 10

NathanFrasier commented 2 years ago

Image representing the error as seen on my system. image

NathanFrasier commented 2 years ago

Chrome update (now 96.0.4664.110) appears to have fixed the issue as well. Thanks!

danfishgold commented 2 years ago

oh wow that image was not what I was expecting! in any case I'll try to make long files easier to work with :)