CodeRoyale / userAPI

User API for CodeRoyale
6 stars 1 forks source link

[ 🔧 Configuration files : Code-Setup ] Eslint Configured #2

Closed donald0109 closed 4 years ago

donald0109 commented 4 years ago

Eslint Configured with air bnb style guide.

donald0109 commented 4 years ago

Do we need the eslint plugin for react and react-hook

Yes, we need eslint plugin for react for sure as we are developing the app in react as per the resources I saw.

SAchu47 commented 4 years ago

Do we need the eslint plugin for react and react-hook

Yes, we need eslint plugin for react for sure as we are developing the app in react as per the resources I saw.

Their is no react code in backend

donald0109 commented 4 years ago

Do we need the eslint plugin for react and react-hook

Yes, we need eslint plugin for react for sure as we are developing the app in react as per the resources I saw.

Their is no react code in backend

But these dependencies will be necessary for the working of the app. If not necessary will remove the dependencies.

SAchu47 commented 4 years ago

But these dependencies will be necessary for the working of the app. If not necessary will remove the dependencies.

Then we will keep it. If at any moment it seems not useful can remove it. And can you please provide reference links so anyone new comes can refer it. Well Done nice work @donald0109

sastaachar commented 4 years ago

Also go through contribution guide in the contribution branch.

SAchu47 commented 4 years ago

@sastaachar @donald0109 what's the use of eslint-plugin-node ? And don't we need prettier for code formatting?

sastaachar commented 4 years ago

@sastaachar @donald0109 what's the use of eslint-plugin-node ? And don't we need prettier for code formatting?

sastaachar commented 4 years ago

@sastaachar @donald0109 what's the use of eslint-plugin-node ? And don't we need prettier for code formatting?

eslint-plugin-node is use for node.js specific linting , and prettier is for using some more personalized changes defined in the prettier config

Rec0iL99 commented 4 years ago

Awesome work @donald0109