search

CodeRoyale / userAPI

User API for CodeRoyale
6 stars 1 forks source link

[✨ New feature: API] Github Authentication using Passport #29

Closed afif1400 closed 2 years ago

afif1400 commented 3 years ago

Description

Have added Github strategy got authentication using GitHub and added a jwt strategy that can be used as a common jwt authentication middleware.

SAchu47 commented 3 years ago

@afif1400 follow the PR format. The title wasn't following it, for now, I have corrected it.

afif1400 commented 3 years ago

@afif1400 follow the PR format. The title wasn't following it, for now, I have corrected it.

okay, I'll follow that.

afif1400 commented 3 years ago

@afif1400 you haven't integrated the feature into the route. Please do check on it

Yeah.... before doing that, shall I follow the pattern that you have implemented for authentication or shall I seperate github and also check the code, let me know if I should contain.

SAchu47 commented 3 years ago

@afif1400 you haven't integrated the feature into the route. Please do check on it

Yeah.... before doing that, shall I follow the pattern that you have implemented for authentication or shall I seperate github and also check the code, let me know if I should contain.

Yes @afif1400 follow the pattern in which it is presently implemaneted in the signup and login route that would be great.

SAchu47 commented 3 years ago

Hye, @afif1400 any progress