search

CodeSequence / jasmine-marbles

Marble testing helpers for RxJS and Jasmine
MIT License
117 stars 39 forks source link

Deprecation error on jasmine 4.0 #89

Closed Zialus closed 2 years ago

Zialus commented 2 years ago 
ERROR: 'DEPRECATION: The matcher factory for "toBeObservable" accepts custom equality testers, but this parameter will no longer be passed in a future release. See <https://jasmine.github.io/tutorials/upgrading_to_Jasmine_4.0#matchers-cet> for details.
Error: 
    at <Jasmine>
    at addMatchers (http://localhost:9876/_karma_webpack_/webpack:/node_modules/jasmine-marbles/es6/index.js:92:1)
    at UserContext.<anonymous> (http://localhost:9876/_karma_webpack_/webpack:/node_modules/jasmine-marbles/es6/index.js:130:1)
    at ZoneDelegate.invoke (http://localhost:9876/_karma_webpack_/webpack:/node_modules/zone.js/fesm2015/zone.js:372:1)
jrdutton commented 2 years ago

Yep, seeing this too. Thank you for raising it.

brandonroberts commented 2 years ago

Would someone like to put in a PR for this?

Zialus commented 2 years ago

If I understand correctly, all that needs to be changed is to remove _equalityTester from this line https://github.com/CodeSequence/jasmine-marbles/blob/master/index.ts#L71

I'm not sure about the release process though, given the current situation with 3 versions: 0.10.0-beta.0 | 0.9.1 | 0.8.4

brandonroberts commented 2 years ago

Yes, that looks correct on the change. For the release, it would be under the 0.9.x release so you can just target the master branch for the PR.