CodeSeven / toastr

Simple javascript toast notifications
http://www.toastrjs.com
MIT License
11.98k stars 2.04k forks source link

Not accessible with screen readers like JAWS and NVDA #500

Open pranavkaushik opened 7 years ago

pranavkaushik commented 7 years ago

When the toastr pops out the screen reader couldn't catch the toastr message. This can be resolved by adding aria-live="assertive" and role="alert" for the toastr message tag.

Kindly update the same.

Thanks.

blimey85 commented 7 years ago

This would be a good thing to support. @pranavkaushik, can you add this in and then create a pull request so it can be merged. Thanks!

elmoaaron commented 7 years ago

Very important!

Nindouja commented 5 years ago

I opened the pull request https://github.com/CodeSeven/toastr/pull/598 to fix that.

AdrienNguyenWorldline commented 5 years ago

+1 on that behaviour, there is no drawback in adding the right aria tags PR should be merged to the main project