search

CodeShield-Security / SPDS

Efficient and Precise Pointer-Tracking Data-Flow Framework
Eclipse Public License 2.0
66 stars 12 forks source link

WIP: Update Soot Dependency #8

Closed AnakinRaW closed 4 years ago

AnakinRaW commented 4 years ago

IMPORTANT:

For some reason VectorTest (test2, test4, test5, test6) fails on Java >= 9 with message: 

java.lang.RuntimeException: Unsound results: [MustBe [s (typestate.tests.VectorTest.<typestate.tests.VectorTest: void test2()>) @ mustBeInAcceptingState(s) in state ACCEPTING]]

    at test.IDEALTestingFramework.analyze(IDEALTestingFramework.java:167)
    at test.IDEALTestingFramework$2.internalTransform(IDEALTestingFramework.java:134)
    at soot.SceneTransformer.transform(SceneTransformer.java:36)
    at soot.Transform.apply(Transform.java:102)
    at soot.ScenePack.internalApply(ScenePack.java:35)
    at soot.Pack.apply(Pack.java:117)
    at test.core.selfrunning.AbstractTestingFramework.analyze(AbstractTestingFramework.java:85)
    at test.core.selfrunning.AbstractTestingFramework.beforeTestCaseExecution(AbstractTestingFramework.java:40)

This error also happens in the CROSSING/SPDS repo!

Tested with Java 11.0.7 and soot 4.2.1 and soot 4.3.0-SNPSHT

copumpkin commented 4 years ago

Is this still WIP? It looks like you figured out how to make the tests pass, right?

johspaeth commented 4 years ago

LGTM thanks @AnakinSklavenwalker, let me know if I can merge.

AnakinRaW commented 4 years ago

@johspaeth it depends on you want to address the VectorTest thing. CI passes because it uses Java 8. I'm however unable to understand why this test fails for Java > 8. Also I don't know which impact this has. So if this test represents something you need for every-day usage i'd this should be fixed first. If this test is artificial I'd say you can do the merge.

johspaeth commented 4 years ago

Thanks a lot @AnakinSklavenwalker

I'll do the merge and open an issue about the failing test cases for > Java 9.