search

CodeSleeve / asset-pipeline

This Laravel 4 package provides a very simple and easy to use asset pipeline. It was heavily inspired by the Rails asset pipeline. We make use of the wonderful Assetic package to help with pre-compliation!
http://www.codesleeve.com
MIT License
489 stars 53 forks source link

Multiple bugs in assets:generate #137

Closed marsderp closed 10 years ago

marsderp commented 10 years ago

Bug: [LogicException] An option named "env" already exists Removed the env option and added environment option exists check.

Bug: Class 'Codesleeve\\Sprockets\\StaticFileGenerator' not found StaticFileGenerator should be StaticFilesGenerator

Bug: Undefined index: routing.prefix $config['routing.prefix'] changed to $config['routing']['prefix']

Additional bugs uncovered:

assets:generate does not concat files or process directives in application.js/css. Resulting in environments in concat config linking to a single, empty application.css/js file. Environments excluded in concat are linked to the individual css/js files as expected.

application.css/js files are empty no matter the assets:generate environment.

assets:clean throws:

{
   "error":{
      "type":"Symfony\\Component\\Debug\\Exception\\FatalErrorException",
      "message":"Cannot access private property Codesleeve\\AssetPipeline\\AssetPipeline::$parser",
      "file":"C:\\xampp\\htdocs\\brands\\vendor\\codesleeve\\asset-pipeline\\src\\Codesleeve\\AssetPipeline\\Commands\\AssetsCleanCommand.php",
      "line":74
   }
}
marsderp commented 10 years ago

Another bug I just encountered: .scss files are compiled and renamed to .css, but it is still being linked to the .scss file, which results in the controller being reached because .htacess cannot find the static file.

Possible solution would be to leave the file extensions alone after compiling/copying the files.

kdocki commented 10 years ago

lol... hey @marsd I'm still working on assets:generate stuff... I've got to write some tests for it too

kdocki commented 10 years ago

@marsd there are bigger issues here I'm having to address. We can't just keep file names the same though it'll cause problems. I am going to close this PR but I am still working on this...

SerafimArts commented 9 years ago

in last stable version 2.0.3 artisan assets:generate

{"error":{
  "type":"Symfony\\Component\\Debug\\Exception\\FatalErrorException",
  "message":"Class 'Codesleeve\\AssetPipeline\\Commands\\Codesleeve\\Sprockets\\StaticFileGenerator' not found",
  "file":"E:\\@server\\projects\\AniPoisk\\vendor\\codesleeve\\asset-pipeline\\src\\Codesleeve\\AssetPipeline\\Commands\\AssetsGenerateCommand.php",
  "line":39
}}