search

CodeSleeve / stapler

ORM-based file upload package for php.
http://codesleeve.com
Other
538 stars 144 forks source link

Return the class name and namespace lowercased #160

Closed brunodevel closed 8 years ago

brunodevel commented 8 years ago

Return the ":class_name" and ":namespace" interpolations lowercased. For instance, this would change the URL for a product image from "uploads/Product/image..." to "uploads/product/image".

The purpose of this change is to make links more consistent with the naming conventions commonly used for files and folders in web apps.

tabennett commented 8 years ago

Nix boxes are case sensitive; this would break existing applications would it not? I'm disagreeing with you that these should probably be lower-cased, but I can't merge this into master if it's a big of a BC break as I think it is. I have a develop branch set up for Stapler 2.0 that would be much better suited for this. If you can PR it there I think we could get this merged in.

brunodevel commented 8 years ago

@tabennett you are right. This could be a big BC break. I will create a PR for the develop branch. Thanks.