search

CodeSmile-0000011110110111 / UnityResolutionDialog

Replacement for Unity's built-in resolution dialog (aka Screen Selector) that was removed in Unity 2019.3. Works both up front (simply make it the first scene) and as a popup dialog (default key: ESC). Intended for development / testing purposes but can also be used in production.
MIT License
111 stars 20 forks source link

Turn into package & new Input System #2

Closed RaphaelBuquet closed 4 years ago

RaphaelBuquet commented 4 years ago

Changes

This turns this repo from a Unity Project into a Package that can be installed with the Package Manager.

The .unitypackage has been deleted. I wouldn't support this use case anymore, as the Package Manager seems vastly superior to me.

This also "fixes" errors with the new Input System, without adding support for it (as it would add a dependency). Indeed, I have refactored PopupHandler to extract DefaultInputsHandler, which can be replaced by a custom InputsHandler to use the new Input System. I can provide an example if needed. (should this be added to the README under "New Input System"?)

Lastly, I have added namespaces to all scripts.

Maintenance

To maintain the package, the repo should be cloned inside of an empty Unity Project. The repository root will be located under /Assets/NewResolutionDialog. (should this be added to the README under "Contributing"?)

Publishing updates

Any new release must be commited on the release/stable branch (see Installation in README). If this pull request is merged, that branch must be created.

See also

Installing from a Git URL: https://docs.unity3d.com/Manual/upm-ui-giturl.html Input System doc: https://docs.unity3d.com/Packages/com.unity.inputsystem@1.0/manual/index.html Migrating to the new Input System: https://docs.unity3d.com/Packages/com.unity.inputsystem@1.0/manual/Migration.html

CodeSmile-0000011110110111 commented 4 years ago

Awesome! Thanks for making this and for the commendable documentation and tips! I just accepted the pull request without diving in deeply, no time to test right now.