search

CodeSpaceHQ / MENGEL

A framework that applies machine learning algorithms and automates the process of finding the right algorithm for the job.
6 stars 1 forks source link

Tayo image #131

Closed telelu03 closed 7 years ago

telelu03 commented 7 years ago

Okay...this should be better. :)

I'm still working on getting the pixel information into another consumable format, should be done by either tonight or tomorrow night.

asclines commented 7 years ago

See here for my initial review. Here's my overall review: Folder Structure: None ?? What is going on here? Your files should not be in the root project folder like that. Please move them to their appropriate sub-folders to follow our organization schema.

Print Statements: Should only be used for exceptions

Modular: Currently, all the code runs as a script. Please change this to be in methods so that it can be incorporated into the rest of the pipeline. As of now this code is NOT usable as it cannot be included in the rest of the project

Also what is that zip folder? Please remove it.

telelu03 commented 7 years ago

Yeah most of the print statements are just for my benefit to see what's going on...I can change/take them out. Gonna change the module with your suggestions

asclines commented 7 years ago

Why is the file called processfolder2.py?

ZakeryFyke commented 7 years ago

Why delete the imgProcess file? You might be right in doing so, I'm just curious.

asclines commented 7 years ago

@telelu03 now would be as good a day as any to respond.

telelu03 commented 7 years ago

@asclines I called it processFolder2.py just to distingish it from my earlier version...I can change the name back.

@ZakeryFyke the imgProcess.py module was more of a Knowledge Acquisition thing rather than an actual module...I shouldn't have added it in the first place.

asclines commented 7 years ago

@telelu03 yeah, go ahead and remove the 2 as we don't need version control in our naming. That's why we are on GitHub in the first place. Also, when you are renaming it, why don't you go ahead and rename it process_folder.py to follow our coding style.

asclines commented 7 years ago

Where's the testing?

telelu03 commented 7 years ago

@asclines gonna work on tests and documentation over the break

ZakeryFyke commented 7 years ago

@telelu03 You say a few times here that these functions convert images to numpy arrays. What's the actual content of the numpy array? At one point you say that the image is being converted to a numpy array, but at another you say the function returns a numpy array of images.

ZakeryFyke commented 7 years ago

@telelu03 Question regarding the contents of the Numpy array still stands.

telelu03 commented 7 years ago

That's my fault, I was unclear with the wording on get_image_array. The array it returns contains pixel info on the image, and the function returns an array of these arrays

telelu03 commented 7 years ago

I don't know how my module ended up not being a Python file. Has been fixed