search

CodeTogether-Inc / CodeTogether-Live

Repository for issues, documentation and more for codetogether.com and associated VS Code extension and Eclipse plugins.
Other
103 stars 12 forks source link

Go to definition sets the cursor to the last edited location instead of def in certain combinations #315

Closed toddewilliams closed 3 years ago

toddewilliams commented 3 years ago

Describe the bug When hosting with IntelliJ 2020.3.2, 2020.2.4, Eclipse (2020-12) and using a browser as a client: invoking "Goto Definition" causes the client editor to jump to the last edit location instead of navigated class.

To Reproduce Steps to reproduce the behavior: CASE I: Client jumps to the last edit location instead of navigated class.

  1. Start and Join the session.
  2. As a Host open class A which is a parent of class B. [eg. class B extends A{}]
  3. Intellij Host: As a Host, just edit some where at the end of the file & do save.
  4. Eclipse Host: As a Host, either just put the cursor somewhere OR do some edit & save.
  5. Now, Open file B, and jump to the class A via any method or class Name.
  6. Actual: Host jumps to the last edit location instead of the method/class being navigated.

NOTE: Both Host/Client should be on different machine & this is not reproducible across cross IDE sessions (IJ<-->Eclipse, Eclipse<-->IJ, Eclipse/IJ<-->Vsc). Also not reproducible if VSCode is the host.

Expected behavior The client should go to the definition requested.

Screenshots If applicable, add screenshots to help explain your problem.

CodeTogether Host

Browser Participant

Workaround (if any) Use an IDE as a client

GenuitecKanbot commented 3 years ago

Happy to report this issue is resolved! (from Kanbanbot)