search

CodeTogether-Inc / CodeTogether-Live

Repository for issues, documentation and more for codetogether.com and associated VS Code extension and Eclipse plugins.
Other
103 stars 12 forks source link

Error logged in IntelliJ host when performing "change method return type" quick fix #316

Closed toddewilliams closed 3 years ago

toddewilliams commented 3 years ago

Describe the bug When hosting in IntelliJ, if a participant performs a "Change method return type" quick fix, the following error is logged on the host: "Refactorings should not be started inside write action"

To Reproduce Steps to reproduce the behavior:

  1. Host a shared session in IntelliJ
  2. From a client, open a Java class containing a method with a return value
  3. Apply the "Change method type" quick fix
  4. Note the error in the log

Expected behavior The return type should be changed and the error should not be logged.

Screenshots https://gyazo.com/0a6582e414c9f31d6596eb1bc43fa03b

CodeTogether Host

Browser Participant

Additional context Log: error.txt

GenuitecKanbot commented 3 years ago

Happy to report this issue is resolved! (from Kanbanbot)