search

CodeTogether-Inc / CodeTogether-Live

Repository for issues, documentation and more for codetogether.com and associated VS Code extension and Eclipse plugins.
Other
103 stars 12 forks source link

Abap Support can't open files from Abap list #327

Open uxkjaer opened 3 years ago

uxkjaer commented 3 years ago

Describe the bug When using code together, the client can't open types like programs other than the host has opened, while they are still visible in the explorer. You can however open classes fine.

To Reproduce Steps to reproduce the behavior:

  1. Expand the Abap tree
  2. Expand the program tree
  3. Try to open a program
  4. In VS Code nothing happens, Eclipse crashed for me

Expected behavior All types should open

CodeTogether Host

IDE Participant

toddewilliams commented 3 years ago

@uxkjaer I'm a bit confused reading this bug description along with the one for #328.

Specifically, here you mention that clients can't open "programs other than the host has opened, while they are still visible in the explorer." That makes it sound like clients should be able to open any project shown in the host's project explorer. Is that true?

I ask because in #328 you state: "When hosting a session, the client can explore the class list of unopened and therefore unauthorized projects and view the code."

I'm now confused as to whether or not clients should be able to: 1) See a list of projects on the hosts screen? Perhaps these can be hidden with the .codetogether.ignore capability? 2) If the list should be visible in all/some instances, should the client be able to open projects that the host has not opened? 3) Should clients be able to open other projects that the host has not opened?

uxkjaer commented 3 years ago

Sorry I can see that. In this bug I mean only types within the same project. I can create a little video today to show the issues.