search

CodeTogether-Inc / CodeTogether-Live

Repository for issues, documentation and more for codetogether.com and associated VS Code extension and Eclipse plugins.
Other
103 stars 12 forks source link

Include required ingressClassName for Ingress #372

Closed SimonRupar closed 2 years ago

SimonRupar commented 2 years ago

Resolves: https://github.com/Genuitec/CodeTogether/issues/370

Includes required spec.ingressClassName as described in https://kubernetes.io/docs/concepts/services-networking/ingress/#the-ingress-resource

yurrriq commented 2 years ago

Since the Ingress template handles the deprecated annotation, and it's useless in modern k8s, we should remove it from values.yaml.

https://github.com/Genuitec/CodeTogether/blob/f52ad5a8c33edc005fc04369d72c739c85fa1100/helm/templates/ingress.yaml#L4-L8

SimonRupar commented 2 years ago

@wgalanciak, @yurrriq I have updated the changes based on PR.