search

CodeWithAloha / ACLU

Code for Hawaii + ACLU app to show public access rights
https://aclu.codeforhawaii.org/#/
MIT License
23 stars 12 forks source link

Add animation to spinner/loading component #161

Closed felimartina closed 5 years ago

felimartina commented 6 years ago

We created a Loading component to use every time we are doing some async processing (like https calls to the backend api). Right now we only show holo holo logo in there. It will be nice to add some animation to that loading screen so that the user understands that there is something going on behind the scenes.

Use GSAP and the following article to implement:

https://blog.usejournal.com/vue-js-gsap-animations-26fc6b1c3c5a

bronsonavila commented 6 years ago

Would I be able to be assigned to this task? I was able to integrate the animations from the referenced blog into the Loading component's spinner-image. See: https://github.com/bronsonavila/ACLU/blob/ba-spinner/frontend-v2/src/components/Loading.vue. If this appears acceptable, I can submit a PR for further review.

felimartina commented 6 years ago

Hey @bronsonavila, sorry for this super late reply! Yes man, go ahead and take it. I checked out what you did...pretty cool! Go ahead and submit a PR!!!

Great job :)

bronsonavila commented 6 years ago

Thanks. PR submitted.