CodeWithAsheville / court-notifications

GNU General Public License v3.0
9 stars 9 forks source link

Updated axios and axios-cookiejar-support to latest versions #186

Closed batwalrus76 closed 7 months ago

batwalrus76 commented 7 months ago

What changes are you introducing?

Updates axios and axios-cookiejar-support to latest stable version.

I am having issues with 1 test working before or after this change. It is related to connecting to twillio. I have followed all of the steps but for some reason, I cannot get the test to pass. There was no change to the arguments passed to these libraries, so I didn't believe this ended up being a major change. I am happy to take another swing at getting things to run or going through testing on heruku, but I would need creds, etc. I also could continue updating other libraries but thought that keeping this to updating the 2 most important libraries that need updating would be fine.

ejaxon commented 7 months ago

Cool! Thank you!

I'm not sure why I thought the API had changed somehow - looking again I see it seems not.

I may not get a chance to test out until next week (I'm taking vacation the second half of the month, but that means this week is pretty intense), but I will do so as soon as I get a chance. In any case I can't see any reason why anything to do with Twilio should be affected (was the failing test the test-webhook one?).

BTW it may make sense to upgrade tough-cookie at the same time (I think it goes from 4.0.0 to 4.1.3 - no breaking changes for us).

batwalrus76 commented 7 months ago

Okay I will do that over the next week