search

CodeWithDennis / filament-select-tree

The multi-level select field lets you pick one or multiple options from a list that is neatly organized into different levels.
MIT License
225 stars 33 forks source link

add rtl for select input #33

Closed ariaieboy closed 11 months ago

ariaieboy commented 1 year ago

I am waiting for this PR to be merged https://github.com/dipson88/treeselectjs/pull/84

CodeWithDennis commented 1 year ago

I am assuming you are gonna add a RTL method?

ariaieboy commented 1 year ago

I am assuming you are gonna add a RTL method?

My implementation does not need any RTL method; users only need to use an RTL locale in laravel, and since the dir will be set as RTL when you use an RTL language in filament, everything is going to work without any configuration.

But it depends on this https://github.com/dipson88/treeselectjs/pull/84 PR. If the project's maintainer decides that using HTML dir is not a good option and we need to introduce a new option to the library, we might need to change more things or add a method.

CodeWithDennis commented 1 year ago

Nice job, sounds good👍

mszabeh commented 1 year ago

@CodeWithDennis Hi, when this PR will be completed?

CodeWithDennis commented 1 year ago

@CodeWithDennis

Hi,

when this PR will be completed?

This is not my PR, he is waiting on a 3rd party.

CodeWithDennis commented 12 months ago

@ariaieboy After you finish the PR, can you add a screenshot so I can see how it looks?

mszabeh commented 11 months ago

@ariaieboy https://github.com/dipson88/treeselectjs/pull/84 PR. released.

CodeWithDennis commented 11 months ago

Is there anything else besides upgrading that needs to be done?

ariaieboy commented 11 months ago

Is there anything else besides upgrading that needs to be done?

Yes we need to pass rtl option to the script. I will update this PR.